Use PHPUnit 8.3 on Travis when possible #33072
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
approved these changes
Aug 8, 2019
Tobion
approved these changes
Aug 8, 2019
fcb3edf to
ea25756
Compare
fabpot
approved these changes
Aug 9, 2019
|
test are failing because of in we may hold this PR untill the next release in order to properly set the mimum version |
this is never needed, we do reference unreleased next-versions and it just works |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 9, 2019
… jderusse) This PR was merged into the 3.4 branch. Discussion ---------- Use PHPUnit 8.3 on Travis when possible | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Followup #33072 to fix dependency resolution Commits ------- 41d94c3 Bump minimal requirements de5256b Use PHPUnit 8.3 on Travis when possible
ea25756 to
6da6dd7
Compare
6da6dd7 to
feac9d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just achieved running PHPUnit 8.2 on PHP 7.4, let's ensure it continues running by using it on a primary job.