[HttpFoundation] Add type-hints #33088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please revert all return-type changes, we're not ready to do them. |
1b9f1b6 to
4588228
Compare
ro0NL
reviewed
Aug 9, 2019
587f6fb to
b0f575c
Compare
derrabus
reviewed
Aug 9, 2019
derrabus
reviewed
Aug 9, 2019
derrabus
reviewed
Aug 9, 2019
derrabus
reviewed
Aug 9, 2019
derrabus
requested changes
Aug 9, 2019
src/Symfony/Component/HttpFoundation/Session/Storage/Handler/RedisSessionHandler.php
Show resolved
Hide resolved
b0f575c to
7fa1d81
Compare
e2820cc to
36373fa
Compare
36373fa to
b1be9ce
Compare
nicolas-grekas
requested changes
Aug 11, 2019
There was a problem hiding this comment.
@azjezz up for a PR on 4.4 to take my comments into account? I squashes everything here and made some additional fixes too.
| * @return self | ||
| */ | ||
| public static function fromString($headerValue) | ||
| public static function fromString(?string $headerValue) |
There was a problem hiding this comment.
because we were using it ourselves, we have to accept null unless we submit a deprecation on branch 4.4
b1be9ce to
f449e38
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Aug 11, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [HttpFoundation] some cleanups | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - As found by @azjezz in #33088 Commits ------- f62a3c0 [HttpFoundation] some cleanups
4f4f37f to
61da067
Compare
61da067 to
ead419b
Compare
nicolas-grekas
approved these changes
Aug 11, 2019
|
Thank you @azjezz. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 11, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [HttpFoundation] Add type-hints | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32179 | License | MIT replace #32271 Commits ------- ead419b add type-hints
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace #32271