[Mime] Add Address::fromString #33091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you explain it? how the feature should work |
|
@Shkarsardar see symfony/symfony-docs#12128 |
fabpot
requested changes
Aug 9, 2019
derrabus
requested changes
Aug 9, 2019
derrabus
reviewed
Aug 9, 2019
derrabus
reviewed
Aug 9, 2019
fabpot
reviewed
Aug 9, 2019
sstok
approved these changes
Aug 12, 2019
fabpot
requested changes
Aug 12, 2019
|
Thanks so much for all the effort you put in checking this. |
OskarStark
reviewed
Aug 14, 2019
OskarStark
approved these changes
Aug 19, 2019
OskarStark
reviewed
Aug 19, 2019
fabpot
requested changes
Aug 19, 2019
fabpot
added a commit
that referenced
this pull request
Aug 21, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Mime] Remove NamedAddress | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | yes <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | n/a While working on #33091, we realize that having both `NamedAddress` and `Address` brings some unneeded complexity. Initially, I added both as some headers do not support `NamedAddress`es. But the code already does the right thing by "downgrading" them to `Address` instances. So, let's simplify our internal code and make life easier for our users too. Commits ------- eb7d74e [Mime] Remove NamedAddress
|
@gisostallenberg Can you rebase as #33270 has been merged now? |
1faab70 to
7c82c07
Compare
This will allow to create an Address from a string such as 'Name <name@example.com>'
7c82c07 to
75ea8d0
Compare
|
Thank you @gisostallenberg. |
fabpot
added a commit
that referenced
this pull request
Aug 22, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Mime] Add Address::fromString | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #33086 | License | MIT | Doc PR | symfony/symfony-docs#12128 This will allow to create a Address from a string such as 'Name <name@example.com>' Example: ```php $address = Address::fromString("Name <name@example.com>"); ``` Commits ------- 75ea8d0 Add Address::fromString
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to create a Address from a string such as 'Name name@example.com'
Example: