[DI] Validate class-like service IDs #33111
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From the original issue, im not sure happens in 3.4, i got the error at https://github.com/symfony/symfony/pull/33111/files#diff-81d8d6906c0de563850dc240f5a1d213R77 |
| @@ -65,6 +65,14 @@ public function process(ContainerBuilder $container) | |||
| $id | |||
| )); | |||
| } | |||
| if (preg_match('/^\\\\[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*+(?:\\\\[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*+)++$/', $id)) { | |||
| throw new RuntimeException(sprintf( | |||
| 'The definition for "%s" has no class attribute, and appears to reference a class or interface. ' | |||
There was a problem hiding this comment.
and appears to reference a class or interface
actually not, since the class doesn't exist
that + the fact that the message reported in #33092 is not the one just below, I'm not sure this PR is the correct answer.
There was a problem hiding this comment.
you're right. Let's continue in #33108
AFAIK the if block at L51 is now dead code :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative approach of #33092 for 3.4 (enables to continue #33108 for 4.3)
cc @fabpot @nicolas-grekas