[FrameworkBundle] Added --sort option for TranslationUpdateCommand #33117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
k0d3r1s
commented
Aug 11, 2019
•
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #33014 |
| License | MIT |
| Doc PR | symfony/symfony-docs#12136 |
| Added sorting option for translation:update command |
Simperfit
reviewed
Aug 12, 2019
Simperfit
reviewed
Aug 12, 2019
src/Symfony/Bundle/FrameworkBundle/Tests/Command/TranslationUpdateCommandTest.php
Show resolved
Hide resolved
Simperfit
reviewed
Aug 12, 2019
src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php
Outdated
Show resolved
Hide resolved
yceruto
reviewed
Aug 13, 2019
|
what happened to travis builds? I just applied patch and everything went wrong |
fabpot
approved these changes
Sep 8, 2019
src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php
Outdated
Show resolved
Hide resolved
| @@ -88,11 +93,11 @@ protected function configure() | |||
| message. | |||
|
|
|||
| Example running against a Bundle (AcmeBundle) | |||
| <info>php %command.full_name% --dump-messages en AcmeBundle</info> | |||
| <info>php %command.full_name% --dump-messages --sort=asc en AcmeBundle</info> | |||
There was a problem hiding this comment.
I would remove the --sort in the 2 existing commands and add a sentence explaining the sort option with a new example.
fabpot
approved these changes
Sep 8, 2019
|
Thank you @k0d3r1s. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Sep 18, 2019
…ate command (k0d3r1s) This PR was squashed before being merged into the 4.4 branch (closes #12136). Discussion ---------- Added documentation for --sort option in translation:update command Documentation for symfony/symfony#33117 Commits ------- aae353a Added documentation for --sort option in translation:update command
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.