[WebLink] implement PSR-13 directly #33122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
requested changes
Aug 12, 2019
src/Symfony/Component/WebLink/Tests/GenericLinkProviderTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/WebLink/Tests/GenericLinkProviderTest.php
Outdated
Show resolved
Hide resolved
derrabus
reviewed
Aug 12, 2019
a81e5d3 to
b570ee1
Compare
derrabus
approved these changes
Aug 12, 2019
dunglas
approved these changes
Aug 12, 2019
lyrixx
approved these changes
Aug 12, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Aug 12, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [WebLink] implement PSR-13 directly | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Implementing PSR-13 is simple enough and the repo we're using is [freezed](https://github.com/php-fig/link-util/pulls). This also allows us to add some type declarations. We're going to need them before merging #30323. Commits ------- b570ee1 [WebLink] implement PSR-13 directly
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Aug 13, 2019
…s-grekas) This PR was merged into the 4.4 branch. Discussion ---------- Use PSR-13 implementation from WebLink component Follows symfony/symfony#33122 Commits ------- 0674414 Use PSR-13 implementation from WebLink component
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing PSR-13 is simple enough and the repo we're using is freezed.
This also allows us to add some type declarations. We're going to need them before merging #30323.