[FrameworkBundle] Sort tagged services #33128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simperfit
reviewed
Aug 13, 2019
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/Descriptor.php
Outdated
Show resolved
Hide resolved
8a84413 to
ffb77e8
Compare
ismail1432
reviewed
Aug 14, 2019
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/Descriptor.php
Outdated
Show resolved
Hide resolved
ffb77e8 to
1aa12d0
Compare
teohhanhui
reviewed
Aug 27, 2019
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/Descriptor.php
Outdated
Show resolved
Hide resolved
stof
reviewed
Aug 28, 2019
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/Descriptor.php
Outdated
Show resolved
Hide resolved
ae6e875 to
42c0188
Compare
Simperfit
approved these changes
Aug 28, 2019
67706ac to
2f2325e
Compare
2f2325e to
54cef2a
Compare
javiereguiluz
approved these changes
Sep 22, 2019
src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/builder_priority_tag.xml
Show resolved
Hide resolved
fabpot
approved these changes
Sep 25, 2019
|
Thank you @krome162504. |
fabpot
added a commit
that referenced
this pull request
Sep 25, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] Sort tagged services | Q | A | ------------- | --- | Branch? | 4.4 <!-- see below --> | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32439 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | - Hi This PR it's to improve DX when `debug:container` command is use with tag argument by sorting them by priority (More details in linked issue). Currently they are sort by alphabetical order. Commits ------- 54cef2a [FrameworkBundle] Sort tagged service by priority
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
This PR it's to improve DX when
debug:containercommand is use with tag argument by sorting them by priority (More details in linked issue).Currently they are sort by alphabetical order.