[DI] deprecate support for non-object services #33137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't update the changelog because I think this is not common enough to require one. Also, this doesn't prevent private scalar services, because those don't get through the patched methods. That's why this won't break places where we do define scalar services. |
|
Can we also deprecate scalars in |
e2196ad to
7c01c4c
Compare
|
Here you are :) |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 13, 2019
…s-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [DI] deprecate support for non-object services | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32411 | License | MIT | Doc PR | - Follows #32432 /cc @derrabus Prepares for adding the `?object` return-type on master. Commits ------- 7c01c4c [DI] deprecate support for non-object services
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #32432 /cc @derrabus
Prepares for adding the
?objectreturn-type on master.