Remove superfluous phpdoc tags #33151
Conversation
| @@ -188,7 +188,6 @@ public function setAutocompleterCallback(callable $callback = null): self | |||
| /** | |||
| * Sets a validator for the question. | |||
| * | |||
| * @param callable|null $validator | |||
| * | |||
There was a problem hiding this comment.
can extra blank lines be removed by the tool too?
There was a problem hiding this comment.
hmm shouldn't fabbot.io catch those ?
I ran php-cs-fixer with 'no_superfluous_phpdoc_tags' => ['allow_mixed' => true], as the only rule to speed up things, so others rules from .php_cs.dist might handle these.
What's clear is that the no_superfluous_phpdoc_tags doesn't handle it itself after it's cleaning
I'll check my guess and see if there's even another rule we can add that can do this check if not in .php_cs.dist file already
| * @param RawMessage $message | ||
| * | ||
| * {@inheritdoc} | ||
| */ |
There was a problem hiding this comment.
I thought it was a typo as the annotated param here is $message, probably copy pasted from the function above, while the real param is $email here but with no indications on it's type it seems. So I decided to simply remove it.
I'll keep the inheritdoc though.
| * @param \ReflectionClass $reflectionClass | ||
| * @param array|bool $allowedAttributes | ||
| * @param string|null $format | ||
| * @param string $class |
There was a problem hiding this comment.
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Outdated
Show resolved
Hide resolved
|
Cleaning of some files went a little bit too far and broke some php doc extraction tests 😅, will fix this |
|
Thank you @tigitz |
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #33151). Discussion ---------- Remove superfluous phpdoc tags | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ... | License | MIT As Symfony is moving towards type hinted code, this PR is attempting to remove the now superfluous annotations See #33150 to make this cleaning as an automatic process Commits ------- 608e23c Remove superfluous phpdoc tags
|
This is now merged up to master 🎉 |
As Symfony is moving towards type hinted code, this PR is attempting to remove the now superfluous annotations
See #33150 to make this cleaning as an automatic process