Mark all dispatched event classes as final #33152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobion
commented
Aug 13, 2019
| @@ -20,7 +20,7 @@ | |||
| * | |||
| * @author Fabien Potencier <fabien@symfony.com> | |||
| */ | |||
| class MessageEvent extends Event | |||
| final class MessageEvent extends Event | |||
There was a problem hiding this comment.
@fabpot there is a MessageEvents class in the same mailer namespace. This can easily be confused with the event class and should maybe be renamed or relocated or even made internal.
There was a problem hiding this comment.
isn't MessageEvents the class holding all event names as constants ? This is not internal
There was a problem hiding this comment.
The Mailer MessageEvents is a class used for logging and data collecting. It collects events but is not an event itself.
chalasr
reviewed
Aug 13, 2019
src/Symfony/Component/HttpKernel/Event/FilterControllerArgumentsEvent.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
Aug 14, 2019
javiereguiluz
approved these changes
Aug 14, 2019
lyrixx
approved these changes
Aug 14, 2019
OskarStark
reviewed
Aug 14, 2019
xabbuh
reviewed
Aug 14, 2019
src/Symfony/Component/HttpKernel/Event/FilterControllerArgumentsEvent.php
Outdated
Show resolved
Hide resolved
63 tasks
nicolas-grekas
added a commit
that referenced
this pull request
Aug 21, 2019
…so we can make it final (Tobion) This PR was merged into the 4.3 branch. Discussion ---------- [HttpKernel] Do not extend the new SF 4.3 ControllerEvent so we can make it final | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | unlikely | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | | License | MIT | Doc PR | See #33152 (comment) Remember the ControllerEvent is new in SF 4.3 so we just go back to what it was before 4.3 Commits ------- 00140b6 Do not extend the new SF 4.3 ControllerEvent so we can make it final
nicolas-grekas
approved these changes
Aug 21, 2019
|
Thank you @Tobion. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 21, 2019
This PR was merged into the 4.4 branch. Discussion ---------- Mark all dispatched event classes as final | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | | License | MIT | Doc PR | I think we should mark all our Event classes as final. There is no point in people extending them as the libraries that use the event, will only dispatch this event. So extending events in user-land achieves nothing as the subclasses won't be dispatched. I'm not talking about the base events that are meant to be extended like KernelEvent, but the leaf events like ExceptionEvent, ResponseEvent etc. Then we can also make them real final in 5.0 as the events are value objects that should not be mocked. Commits ------- 4bb38ee Mark all dispatched event classes as final
fabpot
added a commit
that referenced
this pull request
Sep 8, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- Make dispatched events really final | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | | License | MIT | Doc PR | Continuation of #33152 for master Commits ------- 953057f Make dispatched events really final
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should mark all our Event classes as final. There is no point in people extending them as the libraries that use the event, will only dispatch this event. So extending events in user-land achieves nothing as the subclasses won't be dispatched.
I'm not talking about the base events that are meant to be extended like KernelEvent, but the leaf events like ExceptionEvent, ResponseEvent etc.
Then we can also make them real final in 5.0 as the events are value objects that should not be mocked.