Skip to content

[Serializer] Add more parameter types #33185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2019

Conversation

derrabus
Copy link
Member

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32179
License MIT
Doc PR N/A

We missed quite a lot in the Serializer, so I decided to open a separate PR instead of merging the changes into #33154.

@derrabus
Copy link
Member Author

I'm already in love with fabbot's new powers. /cc @tigitz

Bildschirmfoto 2019-08-15 um 12 37 40

@derrabus derrabus force-pushed the improvement/serializer-types branch from 41a5cac to a66589c Compare August 15, 2019 10:40
@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Aug 15, 2019
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet :)

@derrabus derrabus force-pushed the improvement/serializer-types branch 2 times, most recently from 8a6572f to 0b46c1a Compare August 15, 2019 10:53
nicolas-grekas added a commit that referenced this pull request Aug 16, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

[Serializer] Fixed docblocks and parameter names

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32179
| License       | MIT
| Doc PR        | N/A

Backports from #33185.

Commits
-------

50701fe [Serializer] Fixed docblocks and parameter names.
@nicolas-grekas
Copy link
Member

Can be rebased

@derrabus derrabus force-pushed the improvement/serializer-types branch from 0b46c1a to 25cc3f4 Compare August 16, 2019 07:19
@derrabus derrabus force-pushed the improvement/serializer-types branch from 25cc3f4 to 73b17a8 Compare August 16, 2019 07:25
@Tobion
Copy link
Contributor

Tobion commented Aug 17, 2019

Thank you @derrabus.

Tobion added a commit that referenced this pull request Aug 17, 2019
This PR was merged into the 5.0-dev branch.

Discussion
----------

[Serializer] Add more parameter types

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32179
| License       | MIT
| Doc PR        | N/A

We missed quite a lot in the Serializer, so I decided to open a separate PR instead of merging the changes into #33154.

Commits
-------

73b17a8 [Serializer] Add more parameter types.
@Tobion Tobion merged commit 73b17a8 into symfony:master Aug 17, 2019
@derrabus derrabus deleted the improvement/serializer-types branch August 17, 2019 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants