[Serializer] Fixed docblocks and parameter names #33186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
commented
Aug 15, 2019
| @@ -172,17 +172,17 @@ public function normalize($data, $format = null, array $context = []) | |||
| * | |||
| * @throws NotNormalizableValueException | |||
| */ | |||
| public function denormalize($data, $type, $format = null, array $context = []) | |||
| public function denormalize($data, $class, $format = null, array $context = []) | |||
There was a problem hiding this comment.
💡 The parameter is called $class in the interface. This change synchronizes the method signatures.
dunglas
approved these changes
Aug 15, 2019
|
For the record, However, as even interfaces define the constant |
|
@dunglas We can also change |
|
Indeed, maybe should we use |
2aee03d to
50701fe
Compare
|
Done. |
maxhelias
approved these changes
Aug 15, 2019
|
Thank you @derrabus. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 16, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Serializer] Fixed docblocks and parameter names | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32179 | License | MIT | Doc PR | N/A Backports from #33185. Commits ------- 50701fe [Serializer] Fixed docblocks and parameter names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports from #33185.