Skip to content

Fix some docblocks #33197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2019
Merged

Fix some docblocks #33197

merged 1 commit into from
Aug 18, 2019

Conversation

derrabus
Copy link
Member

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

Backports from #33154.

@derrabus
Copy link
Member Author

@tigitz fabbot wants to remove an annotation that I'd like to keep. Is the related to the new CS Fixer rule?

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Aug 16, 2019
@nicolas-grekas
Copy link
Member

New fabbot rule, with not perfect behavior, see PHP-CS-Fixer/PHP-CS-Fixer#4505

@nicolas-grekas
Copy link
Member

Thank you @derrabus.

nicolas-grekas added a commit that referenced this pull request Aug 18, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

Fix some docblocks

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

Backports from #33154.

Commits
-------

df89373 Fix some docblocks.
@nicolas-grekas nicolas-grekas merged commit df89373 into symfony:3.4 Aug 18, 2019
@derrabus derrabus deleted the bugfix/docblocks branch August 18, 2019 07:58
fabpot added a commit that referenced this pull request Aug 18, 2019
…rabus)

This PR was merged into the 4.3 branch.

Discussion
----------

[Workflow] Added doc block for Registry::supports()

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

Follows #33197, prepares #33198.

Commits
-------

c76fd13 Added doc block for Registry::supports().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants