Skip to content

[Monolog] Fixed ElasticsearchLogstashHandler with monolog 2+ #33241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2019
Merged

[Monolog] Fixed ElasticsearchLogstashHandler with monolog 2+ #33241

merged 1 commit into from
Aug 19, 2019
+179 −5

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Aug 19, 2019

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Aug 19, 2019
@lyrixx lyrixx mentioned this pull request Aug 19, 2019
Merged
@nicolas-grekas
Copy link
Member

deps=low fail. Is there any way to keep compat with v1? That'd be great...

@lyrixx lyrixx changed the base branch from master to 4.4 August 19, 2019 15:38
@nicolas-grekas nicolas-grekas modified the milestones: 5.0, next Aug 19, 2019
@lyrixx lyrixx mentioned this pull request Aug 19, 2019
Merged
@nicolas-grekas
Copy link
Member

Thank you @lyrixx.

nicolas-grekas added a commit that referenced this pull request Aug 19, 2019
@nicolas-grekas
bug #33241 [Monolog] Fixed ElasticsearchLogstashHandler with monolog …
a9ace36 
…2+ (lyrixx)

This PR was merged into the 4.4 branch.

Discussion
----------

[Monolog] Fixed ElasticsearchLogstashHandler with monolog 2+

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

1f4ca61 [Monolog] Fixed ElasticsearchLogstashHandler with monolog 2+
@nicolas-grekas nicolas-grekas merged commit 1f4ca61 into symfony:4.4 Aug 19, 2019
@lyrixx lyrixx deleted the monolog-elastic branch August 20, 2019 09:11
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@lyrixx @nicolas-grekas @carsonbot