[HttpKernel] deprecate global dir to load resources from #33258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2d8f649 to
7d210c7
Compare
stof
reviewed
Aug 20, 2019
Tobion
commented
Aug 20, 2019
| @@ -80,23 +80,14 @@ public function getBundle($name); | |||
| * where BundleName is the name of the bundle | |||
| * and the remaining part is the relative path in the bundle. | |||
| * | |||
| * If $dir is passed, and the first segment of the path is "Resources", | |||
There was a problem hiding this comment.
This description and the code is not compatible with #32845
But since we don't need these arguments anymore, it doesn't matter now.
7d210c7 to
db46679
Compare
|
I need to take a look at the functional test setup which fail |
ismail1432
reviewed
Aug 20, 2019
db46679 to
4e615d5
Compare
4e615d5 to
aa82566
Compare
|
Tests are passing. |
nicolas-grekas
approved these changes
Aug 21, 2019
|
Thank you @Tobion. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 21, 2019
…om (Tobion) This PR was merged into the 4.4 branch. Discussion ---------- [HttpKernel] deprecate global dir to load resources from | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #31915 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | Replaces #31958 Here two example deprecations by adding files in the deprecated locations: ``` Overwriting the resource "@AcmeBundle/Resources/config/routing.yaml" with "/vagrant/src/Resources/AcmeBundle/config/routing.yaml" is deprecated since Symfony 4.4 and will be removed in 5.0. Loading the file "foobar.yaml" from the global resource directory "/vagrant/src" is deprecated since Symfony 4.4 and will be removed in 5.0. ``` Commits ------- aa82566 [HttpKernel] deprecate global dir to load resources from
This was referenced Nov 12, 2019
Merged
Merged
maxhelias
reviewed
Nov 19, 2019
| $paths[] = $this->path; | ||
| } | ||
|
|
||
| if (4 !== \func_num_args() || func_get_arg(3)) { |
There was a problem hiding this comment.
This condition is weird no ? Because if we pass $triggerDeprecation on false, it still executed or I miss something ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #31958
Here two example deprecations by adding files in the deprecated locations: