[ErrorHandler] Registering basic exception handler to handle early failures #33260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4a0deb6 to
6a6e730
Compare
6a6e730 to
a2077a2
Compare
fabpot
approved these changes
Aug 20, 2019
|
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Aug 20, 2019
…le early failures (yceruto) This PR was merged into the 4.4 branch. Discussion ---------- [ErrorHandler] Registering basic exception handler to handle early failures | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This behavior was previously handled by the removed `ExceptionHandler` class in #32637. As this method is mainly called during Kernel boot, where nothing is yet available, the Response content is always HTML. Otherwise, If all goes well on booting, this exception handler will be replaced in `DebugHandlersListener` class: https://github.com/symfony/symfony/blob/8073b8abfb82d59c6acabce7cec7bfb3af24738a/src/Symfony/Component/HttpKernel/EventListener/DebugHandlersListener.php#L139 where the advanced exception handler mechanism is activated. Commits ------- a2077a2 Registers basic exception handler to handle early failures
fabpot
added a commit
that referenced
this pull request
Sep 3, 2019
… late failures (yceruto) This PR was merged into the 4.4 branch. Discussion ---------- [ErrorHandler] Registering basic exception handler for late failures | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Follow-up #33260 but when all handlers fail. It'll becomes common since 4.4 where the user has control over the error rendering mechanism. If they make a mistake, we have a support page to show it, currently a blank page is displayed. Commits ------- ffab734 registering basic exception handler for late failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior was previously handled by the removed
ExceptionHandlerclass in #32637.As this method is mainly called during Kernel boot, where nothing is yet available, the Response content is always HTML. Otherwise, If all goes well on booting, this exception handler will be replaced in
DebugHandlersListenerclass:symfony/src/Symfony/Component/HttpKernel/EventListener/DebugHandlersListener.php
Line 139 in 8073b8a
where the advanced exception handler mechanism is activated.