[TwigBridge] Mark all classes extending twig as @final #33269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
approved these changes
Aug 21, 2019
|
There are now some remaining deprecation warnings from SecurityBundle, FB and TwigBridge related to |
|
@yceruto "fixed". I don't see why |
2bb1e91 to
9d37851
Compare
nicolas-grekas
approved these changes
Aug 21, 2019
derrabus
approved these changes
Aug 21, 2019
9d37851 to
d657459
Compare
fabpot
added a commit
that referenced
this pull request
Aug 21, 2019
…(fabpot) This PR was merged into the 4.4 branch. Discussion ---------- [TwigBridge] Mark all classes extending twig as @Final | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes-ish | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | refs #33039 | License | MIT | Doc PR | n/a Classes defining extensions/nodes/node visitors/token parsers should not be changed. They should be final. That would also help with Twig 3.0 which introduces type hints (including return types). Commits ------- d657459 [TwigBridge] Mark all classes extending twig as @Final
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classes defining extensions/nodes/node visitors/token parsers should not be changed. They should be final.
That would also help with Twig 3.0 which introduces type hints (including return types).