[OptionsResolver] Display full nested option hierarchy in exceptions #33295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
commented
Aug 22, 2019
ebe8fff to
356540a
Compare
|
New feature IMO |
yceruto
requested changes
Aug 22, 2019
yceruto
reviewed
Aug 22, 2019
356540a to
a981fc3
Compare
yceruto
approved these changes
Aug 23, 2019
arzzen
approved these changes
Sep 4, 2019
fabpot
approved these changes
Sep 8, 2019
|
Thank you @fancyweb. |
fabpot
added a commit
that referenced
this pull request
Sep 8, 2019
… in exceptions (fancyweb)
This PR was merged into the 4.4 branch.
Discussion
----------
[OptionsResolver] Display full nested option hierarchy in exceptions
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
It kind of improve the DX, especially when you define a lot of nested form options since the file and line cannot be displayed.
```php
$resolver->setDefaults([
'array' => function (OptionsResolver $arrayResolver): void {
$arrayResolver->setRequired('foo');
},
]);
```
Before:
`The required option "foo" is missing.`
After:
`The required option "array[foo]" is missing.`
That can go to 4.3 I guess.
Commits
-------
a981fc3 [OptionsResolver] Display full nested options hierarchy in exceptions
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It kind of improve the DX, especially when you define a lot of nested form options since the file and line cannot be displayed.
Before:
The required option "foo" is missing.After:
The required option "array[foo]" is missing.That can go to 4.3 I guess.