[SecurityGuard] Deprecate returning non-boolean values from checkCredentials() #33308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
requested changes
Aug 23, 2019
chalasr
reviewed
Aug 23, 2019
src/Symfony/Component/Security/Guard/Tests/Provider/GuardAuthenticationProviderTest.php
Outdated
Show resolved
Hide resolved
4a0869d to
0db0ac1
Compare
0db0ac1 to
a0ca3af
Compare
chalasr
approved these changes
Aug 23, 2019
|
Status: Needs Review |
fabpot
approved these changes
Aug 25, 2019
|
Thank you @derrabus. |
fabpot
added a commit
that referenced
this pull request
Aug 25, 2019
… from checkCredentials() (derrabus) This PR was merged into the 4.4 branch. Discussion ---------- [SecurityGuard] Deprecate returning non-boolean values from checkCredentials() | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | prepares #33228 | License | MIT | Doc PR | TODO This PR suggests to deprecate implementations of `Symfony\Component\Security\Guard\AuthenticatorInterface::checkCredentials()` that return non-boolean values. This will allow us to add `bool` as return type declaration in the future. nicolas-grekas#26 (comment) /cc @nicolas-grekas @weaverryan Commits ------- a0ca3af Deprecate returning non-boolean values from checkCredentials().
This was referenced Aug 25, 2019
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Aug 28, 2019
This PR was merged into the 4.4 branch. Discussion ---------- Document the changes to checkCredentials() This PR fixes #12233 by documenting symfony/symfony#33308. Commits ------- d3d7bc2 Document the changes to checkCredentials()
3 tasks
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests to deprecate implementations of
Symfony\Component\Security\Guard\AuthenticatorInterface::checkCredentials()that return non-boolean values. This will allow us to addboolas return type declaration in the future.nicolas-grekas#26 (comment)
/cc @nicolas-grekas @weaverryan