Allow configuring class names through methods instead of class parameters in Doctrine extensions #33319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a4c341b to
4caecaa
Compare
4caecaa to
d481173
Compare
OskarStark
reviewed
Aug 24, 2019
src/Symfony/Bridge/Doctrine/DependencyInjection/AbstractDoctrineExtension.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
Aug 27, 2019
OskarStark
reviewed
Aug 27, 2019
src/Symfony/Bridge/Doctrine/DependencyInjection/AbstractDoctrineExtension.php
Outdated
Show resolved
Hide resolved
…d of class parameters
d481173 to
b53d8cc
Compare
|
@fabpot @OskarStark done. Sorry for the delay. |
OskarStark
approved these changes
Aug 27, 2019
No problem 😃 |
fabpot
approved these changes
Aug 27, 2019
|
Thank you @alcaeus. |
fabpot
added a commit
that referenced
this pull request
Aug 27, 2019
…of class parameters in Doctrine extensions (alcaeus) This PR was merged into the 4.4 branch. Discussion ---------- Allow configuring class names through methods instead of class parameters in Doctrine extensions | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> While removing class parameters for DoctrineBundle 2.0 (see doctrine/DoctrineBundle#630), I noticed that the DoctrineExtension still requires them. This PR adds a new method that keeps legacy behaviour, but will dropped in Symfony 5. Extending classes (mainly DoctrineBundle and DoctrineMongoDBBundle) must implement this method themselves to return the appropriate class names instead of declaring them as class parameters in their service configuration. I'll create a separate for the master branch to make this method abstract in 5.0. The cache driver class names are not being replaced in this PR, as we're dropping support for `doctrine/cache` in DoctrineBundle 2.0. A separate PR will be created to handle those deprecations and to clean up the code. Commits ------- b53d8cc [DoctrineBridge] Allow configuring class names through methods instead of class parameters
This was referenced Nov 12, 2019
Merged
Merged
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While removing class parameters for DoctrineBundle 2.0 (see doctrine/DoctrineBundle#630), I noticed that the DoctrineExtension still requires them. This PR adds a new method that keeps legacy behaviour, but will dropped in Symfony 5. Extending classes (mainly DoctrineBundle and DoctrineMongoDBBundle) must implement this method themselves to return the appropriate class names instead of declaring them as class parameters in their service configuration. I'll create a separate for the master branch to make this method abstract in 5.0.
The cache driver class names are not being replaced in this PR, as we're dropping support for
doctrine/cachein DoctrineBundle 2.0. A separate PR will be created to handle those deprecations and to clean up the code.