Skip to content

[TwigBridge] Throw an exception when one uses email as a context variable in a TemplatedEmail #33323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Aug 25, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets refs #33310
License MIT
Doc PR symfony/symfony-docs#...

@fabpot fabpot force-pushed the email-reserved-var-mime branch from 20aabe2 to 0cc705b Compare August 25, 2019 07:13
@chalasr chalasr added this to the next milestone Aug 25, 2019
fabpot added a commit that referenced this pull request Aug 26, 2019
… a context variable in a TemplatedEmail (fabpot)

This PR was merged into the 4.4 branch.

Discussion
----------

[TwigBridge] Throw an exception when one uses email as a context variable in a TemplatedEmail

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | refs #33310
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

0cc705b [TwigBridge] Throw an exception when one uses email as a context variable in a TemplatedEmail
@fabpot fabpot merged commit 0cc705b into symfony:4.4 Aug 26, 2019
@fabpot fabpot deleted the email-reserved-var-mime branch September 6, 2019 10:41
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
This was referenced Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants