-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Mailer] maintain sender/recipient name in SMTP envelopes #33387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
xabbuh
commented
Aug 30, 2019
Q | A |
---|---|
Branch? | 4.4 |
Bug fix? | yes |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | #33383 |
License | MIT |
Doc PR |
The build failure is unrelated to the changes. |
18339a0
to
c1d2451
Compare
I found some more places. Ready to be reviewed now. |
As Moreover, we are lacking some escaping to flawlessly use addresses names in email headers. AFAIK, commas and double quotes have to be escaped. I use the following code in my project which ATM use the official postmark client: $name = preg_replace('/"/u', '\"', $name);
if (preg_match('/,/u', $name)) {
$name = sprintf('"%s"', $name);
} I quickly looked at RFC, but address grammar can be found in https://tools.ietf.org/html/rfc2822#section-3.4. |
I think this one needs to be rebased on 4.3 as this is a bug fix, right? @xabbuh Can you rebase? |
Thank you @xabbuh. |
…(xabbuh) This PR was merged into the 4.3 branch. Discussion ---------- [Mailer] maintain sender/recipient name in SMTP envelopes | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #33383 | License | MIT | Doc PR | Commits ------- 46ed0e8 maintain sender/recipient name in SMTP envelopes