[Mailer] Change the DSN semantics #33424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
to make it easier to upgrade, should we deprecate the old syntax instead of dropping it directly (which would even transform them to supported |
f6c6f99 to
6e67fa9
Compare
|
@stof The component is marked as experimental. Moving to the next syntax is easy enough IMHO. |
nicolas-grekas
approved these changes
Sep 2, 2019
fabpot
added a commit
that referenced
this pull request
Sep 2, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Mailer] Change the DSN semantics | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | yes | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | symfony/symfony-docs#12258 I'm not very satisfied with the current DSNs for the Mailer. First, the scheme/protocol should use the provider name, then, there is no way to change the host, which would be nice to debug more easily (using a requestb.in service for instance). Before: ``` smtp://USERNAME:PASSWORD@mailgun http://KEY:DOMAIN@mailgun ``` After: ``` mailgun+smtp://USERNAME:PASSWORD@default mailgun+http://KEY:DOMAIN@default # New mailgun+http://KEY:DOMAIN@somewhere.com:99 ``` SMTP DSNs did not change, but the special sendmail one did: Before: ``` smtp://sendmail ``` After: ``` sendmail+smtp://default ``` And for the `null` transport: Before: ``` smtp://null ``` After: ``` null://null ``` Commits ------- 469c989 [Mailer] Change the DSN semantics
|
My concern is that some of the existing DSNs will change meaning without warning the user while still being accepted (all the |
|
We did that for Messenger as we kept the "experimental" status for more than one version. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Sep 16, 2019
This PR was squashed before being merged into the master branch (closes #12258). Discussion ---------- Move to the new DSN format for Mailer Documents symfony/symfony#33424 Commits ------- c9febee Move to the new DSN format for Mailer
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 16, 2019
…uz, tucksaun) This PR was merged into the 4.4 branch. Discussion ---------- [Mailer] Move to the new DSN format Documents symfony/symfony#33424 Cherry-picking #12258 that should have target 4.4 and also add a missing DSN update. Commits ------- a2c607b [Mailer] Move remaining DSN to new format ca56502 Minor tweaks be392bc Move to the new DSN format for Mailer
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not very satisfied with the current DSNs for the Mailer. First, the scheme/protocol should use the provider name, then, there is no way to change the host, which would be nice to debug more easily (using a requestb.in service for instance).
Before:
After:
SMTP DSNs did not change, but the special sendmail one did:
Before:
After:
And for the
nulltransport:Before:
After: