Skip to content

[Mailer] Fix Mailgun support when a response is not JSON as expected #33432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2019

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Sep 2, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32043
License MIT
Doc PR n/a

Sometimes, like when getting a 401, the Mailgun API does not respond with JSON :(

fabpot added a commit that referenced this pull request Sep 2, 2019
…s expected (fabpot)

This PR was merged into the 4.3 branch.

Discussion
----------

[Mailer] Fix Mailgun support when a response is not JSON as expected

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #32043
| License       | MIT
| Doc PR        | n/a

Sometimes, like when getting a 401, the Mailgun API does not respond with JSON :(

Commits
-------

3b2db42 [Mailer] fixed Mailgun support when a response is not JSON as expected
@fabpot fabpot merged commit 3b2db42 into symfony:4.3 Sep 2, 2019
@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Sep 2, 2019
@fabpot fabpot deleted the mailgun-api-errors-fix branch September 6, 2019 10:41
@fabpot fabpot mentioned this pull request Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants