Fix #33427 #33437
Merged
Fix #33427 #33437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e2fea95 to
9cbbc91
Compare
stof
requested changes
Sep 3, 2019
stof
reviewed
Sep 3, 2019
yceruto
requested changes
Sep 3, 2019
yceruto
approved these changes
Sep 3, 2019
fabpot
approved these changes
Sep 3, 2019
|
Thank you @sylfabre. |
fabpot
added a commit
that referenced
this pull request
Sep 3, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Fix #33427 | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #33427 | License | MIT | Doc PR | none Fix #33427 by checking if the message returned by the intl-icu catalog is empty. If yes then the translator returns an empty string instead of running `formatIntl()` which uses the constructor of `MessageFormatter` which throws an exception with empty strings. Commits ------- 414dceb Fix #33427
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #33427 by checking if the message returned by the intl-icu catalog is empty. If yes then the translator returns an empty string instead of running
formatIntl()which uses the constructor ofMessageFormatterwhich throws an exception with empty strings.