[Mailer] Check email validity before opening an SMTP connection #33471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
264f3f6 to
7152c86
Compare
7152c86 to
3a5fe8c
Compare
|
There's a related failure :) |
3a5fe8c to
dc376f5
Compare
|
@nicolas-grekas fixed |
b026b86 to
dc376f5
Compare
nicolas-grekas
approved these changes
Sep 6, 2019
fabpot
added a commit
that referenced
this pull request
Sep 6, 2019
…onnection (fabpot) This PR was merged into the 4.4 branch. Discussion ---------- [Mailer] Check email validity before opening an SMTP connection | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes-ish | New feature? | yes | BC breaks? | no-ish | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | n/a When using an SMTP server to send emails, the connection to the SMTP server happens before being sure that the email to sent is valid. That does not happen with HTTP transports. This pull request implements a new method to be sure that we don't connect to the SMTP server if the email is not valid. Commits ------- dc376f5 [Mailer] Check email validity before opening an SMTP connection
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using an SMTP server to send emails, the connection to the SMTP server happens before being sure that the email to sent is valid. That does not happen with HTTP transports.
This pull request implements a new method to be sure that we don't connect to the SMTP server if the email is not valid.