Fix test fixtures with deprecated method signatures #33484
Conversation
270a42b to
7f638b2
Compare
| @@ -159,17 +104,6 @@ public function testGetResponseNull() | |||
| $this->assertNull($client->getResponse()); | |||
| } | |||
|
|
|||
| public function testGetInternalResponse() | |||
There was a problem hiding this comment.
from #30602, this test is wrong: it relies on a class that extends Response while the class is @final
from #31674, it has already been removed from master, despite the fact it was not marked as legacy.
That's two mistakes in a row, fortunately, the recent improvements of DebugClassLoader will allow catching those before they happen :)
|
PR updated. All reported but the ones about the |
77167df to
3ecb1ea
Compare
3ecb1ea to
cc3e3d5
Compare
|
TIL: I cannot approve my own pull request. 😅 One question though: We’ve already had checks like this one in place: symfony/src/Symfony/Bridge/Monolog/Logger.php Lines 32 to 34 in 5765539 Are those obsolete now or do we intend to keep them? |
we intend to keep them, because there is no silver bullet (DebugClassLoader is not mandatory) |
|
Thank you @derrabus. |
…rabus, nicolas-grekas) This PR was merged into the 4.3 branch. Discussion ---------- Fix test fixtures with deprecated method signatures | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #33483 (partly) | License | MIT | Doc PR | N/A This PR upgrades two fixtures that implemented deprecated method signatures. As far as I can tell, they are used in tests that do not specifically test legacy behavior, so the fixtures should be up to date. Currently, these fixtures cause failing tests on the 4.4 branch. Commits ------- cc3e3d5 Fix more bad tests 592aacf Fix test fixtures with deprecated method signatures.
This PR upgrades two fixtures that implemented deprecated method signatures. As far as I can tell, they are used in tests that do not specifically test legacy behavior, so the fixtures should be up to date. Currently, these fixtures cause failing tests on the 4.4 branch.