Skip to content

[Bridge/Twig] use tty group on testLintDefaultPaths #33490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #33446 (comment)
License MIT
Doc PR -

Note that I still think we should deprecate reading from STDIN when not explicitly asked for, as explained in #33446 (comment)

@nicolas-grekas nicolas-grekas added this to the next milestone Sep 6, 2019
nicolas-grekas added a commit that referenced this pull request Sep 6, 2019
…olas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[Bridge/Twig] use tty group on testLintDefaultPaths

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #33446 (comment)
| License       | MIT
| Doc PR        | -

Note that I still think we should deprecate reading from STDIN when not explicitly asked for, as explained in #33446 (comment)

Commits
-------

3c59bb5 [Bridge/Twig] use tty group on testLintDefaultPaths
@nicolas-grekas nicolas-grekas merged commit 3c59bb5 into symfony:4.4 Sep 6, 2019
@nicolas-grekas nicolas-grekas deleted the tty branch September 7, 2019 20:37
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants