[Mailer] Change DSN syntax #33494
Merged
[Mailer] Change DSN syntax #33494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c29fc96 to
aec11ea
Compare
|
This PR also allows to nest transports. |
aec11ea to
4408910
Compare
nicolas-grekas
approved these changes
Sep 6, 2019
|
would be great to add tests covering the error cases of the parsing (unclosed parenthesis, nesting a parenthesis directly in the argument, passing an unknown function name, garbage at the end, etc...) |
|
@stof I've added some more tests. |
4408910 to
f30dc2b
Compare
f30dc2b to
39dd213
Compare
fabpot
added a commit
that referenced
this pull request
Sep 7, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Mailer] Change DSN syntax | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | yes | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | - The current syntax for failover and roundrobin is confusing. `&&` and `||` do not really convey the right meaning. I realized that while working on a new transport that will send on more than one transport in parallel. `&&` would be a natural fit, but that's already taken. So, this pull request changes the syntax to be more explicit. Commits ------- 39dd213 [Mailer] Change the syntax for DSNs using failover or roundrobin
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current syntax for failover and roundrobin is confusing.
&&and||do not really convey the right meaning. I realized that while working on a new transport that will send on more than one transport in parallel.&&would be a natural fit, but that's already taken.So, this pull request changes the syntax to be more explicit.