Fixed incompatibility between ServiceSubscriberTrait and classes with protected $container property #33521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
a-menshchikov
commented
Sep 9, 2019
| Q | A |
|---|---|
| Branch? | 4.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #33355 |
| License | MIT |
| Doc PR |
| @@ -22,7 +22,7 @@ | |||
| trait ServiceSubscriberTrait | |||
| { | |||
| /** @var ContainerInterface */ | |||
| private $container; | |||
| private $serviceContainer; | |||
There was a problem hiding this comment.
Hum, looking at the code again, the property is the only way to access the container. Which means this change would break anyone using it 100% guaranteed.
That's no-go from BC perspective.
Making the property protected might be the way to go.
nicolas-grekas
approved these changes
Sep 10, 2019
lyrixx
approved these changes
Sep 10, 2019
fabpot
approved these changes
Sep 11, 2019
… protected $container property
|
Thank you @a-menshchikov. |
fabpot
added a commit
that referenced
this pull request
Sep 11, 2019
…lasses with protected $container property (a-menshchikov) This PR was squashed before being merged into the 4.3 branch (closes #33521). Discussion ---------- Fixed incompatibility between ServiceSubscriberTrait and classes with protected $container property | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #33355 | License | MIT | Doc PR | Commits ------- 954dad4 Fixed incompatibility between ServiceSubscriberTrait and classes with protected $container property
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.