[DI] use dirname() when possible #33529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Sep 10, 2019
stof
approved these changes
Sep 10, 2019
82c740e to
0361509
Compare
0361509 to
2eae300
Compare
nicolas-grekas
commented
Sep 10, 2019
| @@ -306,7 +312,7 @@ public function dump(array $options = []) | |||
|
|
|||
| use Symfony\Component\DependencyInjection\Dumper\Preloader; | |||
|
|
|||
| require dirname(__DIR__, 3).'/vendor/autoload.php'; | |||
| require $autoloadFile; | |||
There was a problem hiding this comment.
now with proper detection of autoload.php location
There was a problem hiding this comment.
Do we have any test covering the dumping of this file ?
There was a problem hiding this comment.
yes; not precisely this line but the $classes[] = ... one below
nicolas-grekas
added a commit
that referenced
this pull request
Sep 10, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [DI] use dirname() when possible | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - On second look, I think this works :) Commits ------- 2eae300 [DI] use dirname() when possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On second look, I think this works :)