Skip to content

[Serializer] Add special '*' serialization group that allows any group #33533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

nrobinaubertin
Copy link
Contributor

@nrobinaubertin nrobinaubertin commented Sep 10, 2019

Q A
Branch? 4.4 for features
Bug fix? no
New feature? yes/no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets #32622
License MIT
Doc PR symfony/symfony-docs#...

Hi,
I added support for a special serialization group: '*'.
This group lets any group serialize the attribute marked with it.

The BC break comes from the fact that someone could have used the '*' group in their code.

@nicolas-grekas
Copy link
Member

Can you please update to target 4.4?

@nrobinaubertin nrobinaubertin changed the base branch from master to 4.4 September 10, 2019 16:47
@nrobinaubertin
Copy link
Contributor Author

nrobinaubertin commented Sep 10, 2019

@nicolas-grekas: I'm new to this, I tried to rebase onto the 4.4 branch and it closed the PR ?

Edit: I remade the PR (#33540), sorry for that

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants