Fixed cache pools affecting each other due to an overwritten seed variable #33570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Sep 13, 2019
|
@xabbuh The build is failing on a different component. Is that an issue for this PR? |
|
The failures don't look related to your changes to me. |
|
Ok, then I won't focus on them. Thanks! |
nicolas-grekas
approved these changes
Sep 13, 2019
|
Good catch, thanks @roed. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 13, 2019
…en seed variable (roed) This PR was merged into the 4.3 branch. Discussion ---------- Fixed cache pools affecting each other due to an overwritten seed variable | Q | A | ------------- | --- | Branch? | 4.3 for bug fixes | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #33561 | License | MIT Due to the fact the adapter was added to the cache seed calculation for cache pools, multiple pool definitions could affect each other. The how and why is described in #33561. This PR resolves that issue by using a copy of the seed and mutating only that copy. Commits ------- 29ba7a8 Fixed cache pools affecting each other due to an overwritten seed variable
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the fact the adapter was added to the cache seed calculation for cache pools, multiple pool definitions could affect each other. The how and why is described in #33561. This PR resolves that issue by using a copy of the seed and mutating only that copy.