[TwigBridge] Add row_attr to all form themes #33573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3d53d98 to
b3e9a65
Compare
stof
reviewed
Sep 13, 2019
src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_3_horizontal_layout.html.twig
Outdated
Show resolved
Hide resolved
src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_3_horizontal_layout.html.twig
Outdated
Show resolved
Hide resolved
xabbuh
added a commit
that referenced
this pull request
Sep 25, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Add missing row_attr option to FormType | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix: #33682 - related issue #33573 | License | MIT The #33573 modified Symfony's form themes. But the [FormType](https://github.com/symfony/form/blob/master/Extension/Core/Type/FormType.php) don't allow the option `row_attr` so the OptionResolver throw an exception that the option is unknown. This PR basically add the option and give it to the form view (like `label_attr` do) Commits ------- d711ea2 Add missing row_attr option to FormType
b3e9a65 to
310d6bb
Compare
|
Here is what I did :
|
9146363 to
6ac53d7
Compare
6ac53d7 to
979aef5
Compare
b2c3bfb to
03cdf96
Compare
03cdf96 to
94b04a8
Compare
|
What's the status with this PR? :) |
xabbuh
reviewed
Nov 21, 2019
94b04a8 to
dfdcbb4
Compare
xabbuh
approved these changes
Nov 21, 2019
nicolas-grekas
approved these changes
Nov 28, 2019
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 28, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [TwigBridge] Add row_attr to all form themes | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #33552 | License | MIT | Doc PR | - The rules I applied: - Always done on the first HTML tag of the row. - Current existing row attrs (`class` or `style`) are applied unless they are defined by the `row_attr` override. They can be removed if they are explicitly set to `false`. Starting from: ``` <div class="form-group"> ``` With `row_attr: {foo: "bar"}`: ``` <div foo="bar" class="form-group"> ``` With `row_attr: {class: "ccc"}`: ``` <div class="ccc"> ``` With `row_attr: {foo: "bar", class: false}`: ``` <div foo="bar"> ``` Commits ------- dfdcbb4 [TwigBridge] Add row_attr to all form themes
This was referenced Dec 1, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rules I applied:
classorstyle) are applied unless they are defined by therow_attroverride. They can be removed if they are explicitly set tofalse.Starting from:
With
row_attr: {foo: "bar"}:With
row_attr: {class: "ccc"}:With
row_attr: {foo: "bar", class: false}: