[Draft][WebProfiler] Removed intercept_redirects config option #33607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e7c7f59 to
fddbc09
Compare
stof
reviewed
Sep 17, 2019
| protected $mode; | ||
| protected $excludedAjaxPaths; | ||
| private $cspHandler; | ||
|
|
||
| public function __construct(Environment $twig, bool $interceptRedirects = false, int $mode = self::ENABLED, UrlGeneratorInterface $urlGenerator = null, string $excludedAjaxPaths = '^/bundles|^/_wdt', ContentSecurityPolicyHandler $cspHandler = null) | ||
| public function __construct(Environment $twig, int $mode = self::ENABLED, UrlGeneratorInterface $urlGenerator = null, string $excludedAjaxPaths = '^/bundles|^/_wdt', ContentSecurityPolicyHandler $cspHandler = null) |
There was a problem hiding this comment.
should we have a BC layer for this signature change ? This class is not marked as @internal
There was a problem hiding this comment.
We should mark it as @internal in 4.4 IMHO.
There was a problem hiding this comment.
This class is marked as final, it should be enough ?
There was a problem hiding this comment.
@maxhelias no. BC breaks in argument position is related to using the class, not to extending it.
fddbc09 to
32ceea6
Compare
|
People are apparently using this feature; so we are going to revert it. Sorry for the time you spent on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up of #33507, where
intercept_redirectsconfig option was deprecated, removing it in master.