Skip to content

[Form][SubmitType] Add "validate" option #33609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

fancyweb
Copy link
Contributor

Q A
Branch? 4.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets #8763
License MIT
Doc PR TODO

The second part of the ticket requires more work but is kind of unrelated.

Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a test for the form theme ensuring that the attribute is actually rendered would be a nice bonus. :)

@xabbuh
Copy link
Member

xabbuh commented Sep 21, 2019

@fancyweb Could you rebase here please so that the builds actually pass?

@fancyweb fancyweb force-pushed the form-submit-no-validate branch from 93b69e3 to d5ecb49 Compare September 23, 2019 07:57
@fancyweb
Copy link
Contributor Author

@xabbuh Done + I added the test.

@fancyweb fancyweb force-pushed the form-submit-no-validate branch from d5ecb49 to a2bc06d Compare September 23, 2019 08:33
@xabbuh
Copy link
Member

xabbuh commented Sep 23, 2019

Thank you @fancyweb.

xabbuh added a commit that referenced this pull request Sep 23, 2019
This PR was merged into the 4.4 branch.

Discussion
----------

[Form][SubmitType] Add "validate" option

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | #8763
| License       | MIT
| Doc PR        | TODO

The second part of the ticket requires more work but is kind of unrelated.

Commits
-------

a2bc06d [Form][SubmitType] Add "validate" option
@xabbuh xabbuh merged commit a2bc06d into symfony:4.4 Sep 23, 2019
@fancyweb fancyweb deleted the form-submit-no-validate branch September 23, 2019 21:03
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Sep 24, 2019
This PR was merged into the 4.4 branch.

Discussion
----------

document the validate option

documentation for symfony/symfony#33609

Commits
-------

0ed33d2 document the validate option
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
This was referenced Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants