-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Form][SubmitType] Add "validate" option #33609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darielopper
approved these changes
Sep 20, 2019
xabbuh
approved these changes
Sep 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a test for the form theme ensuring that the attribute is actually rendered would be a nice bonus. :)
@fancyweb Could you rebase here please so that the builds actually pass? |
93b69e3
to
d5ecb49
Compare
@xabbuh Done + I added the test. |
xabbuh
reviewed
Sep 23, 2019
d5ecb49
to
a2bc06d
Compare
yceruto
approved these changes
Sep 23, 2019
Thank you @fancyweb. |
xabbuh
added a commit
that referenced
this pull request
Sep 23, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Form][SubmitType] Add "validate" option | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | #8763 | License | MIT | Doc PR | TODO The second part of the ticket requires more work but is kind of unrelated. Commits ------- a2bc06d [Form][SubmitType] Add "validate" option
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Sep 24, 2019
This PR was merged into the 4.4 branch. Discussion ---------- document the validate option documentation for symfony/symfony#33609 Commits ------- 0ed33d2 document the validate option
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second part of the ticket requires more work but is kind of unrelated.