Skip to content

fix tests depending on other components' tests #33618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Sep 17, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.4 milestone Sep 17, 2019
@xabbuh xabbuh changed the title [FrameworkBundle] fix tests fix tests depending on other components' tests Sep 17, 2019
@xabbuh xabbuh force-pushed the pr-33579 branch 3 times, most recently from c6a7a16 to 224d802 Compare September 17, 2019 15:47
@xabbuh xabbuh marked this pull request as ready for review September 17, 2019 15:59
@fabpot
Copy link
Member

fabpot commented Sep 18, 2019

Thank you @xabbuh.

fabpot added a commit that referenced this pull request Sep 18, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

fix tests depending on other components' tests

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

cd2f3a6 fix tests depending on other components' tests
@fabpot fabpot merged commit cd2f3a6 into symfony:3.4 Sep 18, 2019
@xabbuh xabbuh deleted the pr-33579 branch September 18, 2019 15:30
xabbuh added a commit to xabbuh/symfony that referenced this pull request Sep 19, 2019
…sts (xabbuh)"

This reverts commit 47fb090, reversing
changes made to 6fad4f1.
nicolas-grekas added a commit that referenced this pull request Sep 19, 2019
This PR was squashed before being merged into the 3.4 branch (closes #33637).

Discussion
----------

install from source to include components tests

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

5aa4328 Revert "bug #33618 fix tests depending on other components' tests (xabbuh)"
c792908 install from source to include components tests
nicolas-grekas added a commit that referenced this pull request Sep 19, 2019
* 3.4:
  Re-enable previously failing PHP 7.4 test cases
  Revert "bug #33618 fix tests depending on other components' tests (xabbuh)"
  install from source to include components tests
nicolas-grekas added a commit that referenced this pull request Sep 19, 2019
* 4.3:
  Re-enable previously failing PHP 7.4 test cases
  [PhpUnitBridge] fix uninitialized variable
  Revert "bug #33618 fix tests depending on other components' tests (xabbuh)"
  install from source to include components tests
nicolas-grekas added a commit that referenced this pull request Sep 19, 2019
* 4.4:
  Re-enable previously failing PHP 7.4 test cases
  [PhpUnitBridge] fix uninitialized variable
  [ErrorRenderer] fix Cannot use object of type ErrorException as array exception #33631
  [Twig] Add missing check
  Revert "bug #33618 fix tests depending on other components' tests (xabbuh)"
  install from source to include components tests
  Fix undefined constant and other minor issues
  [Twig] Add NotificationEmail
  ensure compatibility with type resolver 0.5
  Call AssertEquals with proper parameters
  [DependencyInjection] Allow binding iterable and tagged services
  [Twig] Fix Twig config extra keys
  fix tests depending on other components' tests
  Fix lint commands frozen on empty stdin
This was referenced Oct 7, 2019
PhilETaylor pushed a commit to PhilETaylor/symfony that referenced this pull request Sep 6, 2023
* 4.3:
  Re-enable previously failing PHP 7.4 test cases
  [PhpUnitBridge] fix uninitialized variable
  Revert "bug symfony#33618 fix tests depending on other components' tests (xabbuh)"
  install from source to include components tests
PhilETaylor pushed a commit to PhilETaylor/symfony that referenced this pull request Sep 6, 2023
* 4.4:
  Re-enable previously failing PHP 7.4 test cases
  [PhpUnitBridge] fix uninitialized variable
  [ErrorRenderer] fix Cannot use object of type ErrorException as array exception symfony#33631
  [Twig] Add missing check
  Revert "bug symfony#33618 fix tests depending on other components' tests (xabbuh)"
  install from source to include components tests
  Fix undefined constant and other minor issues
  [Twig] Add NotificationEmail
  ensure compatibility with type resolver 0.5
  Call AssertEquals with proper parameters
  [DependencyInjection] Allow binding iterable and tagged services
  [Twig] Fix Twig config extra keys
  fix tests depending on other components' tests
  Fix lint commands frozen on empty stdin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants