[DependencyInjection] Allow binding iterable and tagged services #33623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add a test case? |
f9abfe1 to
2055a55
Compare
|
I added some tests. |
nicolas-grekas
approved these changes
Sep 18, 2019
|
Thank you @lyrixx. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 18, 2019
…d services (lyrixx)
This PR was merged into the 4.4 branch.
Discussion
----------
[DependencyInjection] Allow binding iterable and tagged services
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | yes
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
This will allow:
```yaml
services:
_defaults:
bind:
iterable $rules: !tagged_iterator app.foo.rule
_instanceof:
App\Foo\Rule\RuleInterface:
tags: ['app.foo.rule']
```
Commits
-------
2055a55 [DependencyInjection] Allow binding iterable and tagged services
This was referenced Nov 12, 2019
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Dec 19, 2019
…iners (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [DependencyInjection] Fix binding tagged services to containers | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34913 | License | MIT | Doc PR | - We missed this part in #33623 Commits ------- 9d48ba4 [DependencyInjection] Fix binding tagged services to containers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow: