[FrameworkBundle] Cleanup #33635
Merged
[FrameworkBundle] Cleanup #33635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Sep 19, 2019
There was a problem hiding this comment.
This one might be controversial. Even if these templates are not used anymore, they might be useful for people not using the full-stack framework. I suppose these can also be moved to a new PHP template bundle if some want to still use PHP as a templating language.
nicolas-grekas
approved these changes
Sep 19, 2019
|
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Sep 19, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [FrameworkBundle] Cleanup | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - These PHP templates are no longer used after removing the PHP Templating layer. Commits ------- f1ebb04 Cleanup
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These PHP templates are no longer used after removing the PHP Templating layer.