[Yaml] fix parsing inline YAML spanning multiple lines #33658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Sep 21, 2019
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Tickets | Fix #25239 #25379 #31333 |
| License | MIT |
| Doc PR |
This was referenced Sep 21, 2019
javiereguiluz
approved these changes
Sep 21, 2019
| YAML | ||
| , | ||
| ], | ||
| 'double quoted multi-line string' => [ |
There was a problem hiding this comment.
The YAML content of this test doesn't match the description. It should use double quotes, right?
fabpot
approved these changes
Sep 23, 2019
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Sep 25, 2019
… (xabbuh) This PR was merged into the 4.4 branch. Discussion ---------- [Yaml] fix parsing inline YAML spanning multiple lines | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #25239 #25379 #31333 | License | MIT | Doc PR | Commits ------- 85a5c31 fix parsing inline YAML spanning multiple lines
This was referenced Nov 12, 2019
Merged
Merged
|
Any plans for back-porting this to 3.4.x? |
|
We never add new features in patch releases and since we didn't support the inline notation across multiple lines before this was considered to be a new feature. |
|
Thanks for the quick update, so we and others can use the patch above if they get a validation error with 3.4.x. |
fabpot
added a commit
that referenced
this pull request
Nov 14, 2020
This PR was merged into the 4.4 branch. Discussion ---------- [Yaml] remove unreachable code | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | mistakenly added in #33658 Commits ------- 5907444 remove unreachable code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.