[Mailer] Remove line breaks in email attachment content with Sendgrid API #33672
Conversation
| $email = new Email(); | ||
| $email->from('foo@example.com') | ||
| ->to('bar@example.com') | ||
| ->attach('Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod', 'lorem.txt'); |
There was a problem hiding this comment.
There is no line-break in this content, so this is not testing your patch.
There was a problem hiding this comment.
@stof it does, line-breaks are added by the MIME-compliant base64 encoder:
There was a problem hiding this comment.
This is so confusing that we should add a comment before the ->attach() method. Something like:
// even it content doesn't include new lines, the Base64 encoding performed later may add them
->attach('...)
src/Symfony/Component/Mailer/Bridge/Sendgrid/Tests/Http/Api/SendgridTransportTest.php
Outdated
Show resolved
Hide resolved
| $email = new Email(); | ||
| $email->from('foo@example.com') | ||
| ->to('bar@example.com') | ||
| ->attach('Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod', 'lorem.txt'); |
There was a problem hiding this comment.
This is so confusing that we should add a comment before the ->attach() method. Something like:
// even it content doesn't include new lines, the Base64 encoding performed later may add them
->attach('...)|
Maybe the actual issue is the usage of Btw, this may also impact other API providers. |
|
@stof is right. We had the same kind of issue with |
|
The SendGrid HTTP API requires attachments to be base64 encoded though (but with "strict" base64 i.e. no line-break). But API transports could indeed bypass the encoding system and use |
d329461 to
a28a7f9
Compare
|
Thank you @fyfey. |
…tuart Fyfe) This PR was squashed before being merged into the 4.3 branch. Discussion ---------- [Mailer] Remove line breaks in email attachment content Line breaks are not allowed in attachment content when sending over the API. | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #33671, Closes #32645 | License | MIT | Doc PR | This is a fix for #33671. Send grid's API throws a 400 error when sending email attachments with default base64 encoding. Removing the line breaks resolves this issue. Commits ------- a28a7f9 [Mailer] Remove line breaks in email attachment content
Line breaks are not allowed in attachment content when sending over the
API.
This is a fix for #33671. Send grid's API throws a 400 error when sending email attachments with default base64 encoding.
Removing the line breaks resolves this issue.