[HttpKernel] wrap compilation of the container in an opportunistic lock #33701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c29c2e6 to
051f9a2
Compare
051f9a2 to
dfdd898
Compare
dfdd898 to
0b5b3ed
Compare
stof
reviewed
Sep 26, 2019
fabpot
approved these changes
Sep 27, 2019
javiereguiluz
approved these changes
Oct 2, 2019
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 2, 2019
…pportunistic lock (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [HttpKernel] wrap compilation of the container in an opportunistic lock | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - #32764 (comment) This PR adds a lock around the compilation of the container. When two or more concurrent requests want to compile the container, the first one runs the computation and the others wait for its completion. If for any reasons the lock doesn't work, compilation happens as usual. The effect is visible when developing locally: Here is what all concurrent requests consume now:  And here is what they will consume with this PR (they wait but reuse the just compiled container):  Commits ------- 0b5b3ed [HttpKernel] wrap compilation of the container in an opportunistic lock
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#32764 (comment)
This PR adds a lock around the compilation of the container. When two or more concurrent requests want to compile the container, the first one runs the computation and the others wait for its completion. If for any reasons the lock doesn't work, compilation happens as usual.
The effect is visible when developing locally:
Here is what all concurrent requests consume now:
And here is what they will consume with this PR (they wait but reuse the just compiled container):
