Fix exceptions (PDOException) error code type #33713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
requested changes
Sep 25, 2019
src/Symfony/Component/Messenger/Tests/Exception/HandlerFailedExceptionTest.php
Outdated
Show resolved
Hide resolved
|
We can't allow php -a
php > $e = new Exception('message', 'string');
PHP Warning: Uncaught Error: Wrong parameters for Exception([string $message [, long $code [, Throwable $previous = NULL]]]) in php shell code:1
Stack trace:
#0 php shell code(1): Exception->__construct('message', 'string')
#1 {main}
thrown in php shell code on line 1PHP does not allow it. |
fabpot
approved these changes
Sep 26, 2019
|
Thank you @ed-fruty. |
f3a9850 to
9efa025
Compare
fabpot
added a commit
that referenced
this pull request
Sep 26, 2019
This PR was squashed before being merged into the 4.3 branch (closes #33713). Discussion ---------- Fix exceptions (PDOException) error code type | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #33704 | License | MIT From the [php.net docs](https://www.php.net/manual/en/exception.getcode.php) `Exception::getCode()` description: > Returns the exception code as integer in Exception but possibly as other type in Exception descendants (for example as **string** in PDOException). So if can be string, we convert it to the int in the `HandlerFailedException` but it still string in `nestedExceptiions`. Commits ------- 9efa025 Fix exceptions (PDOException) error code type
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the php.net docs
Exception::getCode()description:So if can be string, we convert it to the int in the
HandlerFailedExceptionbut it still string innestedExceptiions.