Skip to content

[Form][Validator][Intl] Fix tests #33739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2019
Merged

[Form][Validator][Intl] Fix tests #33739

merged 1 commit into from
Sep 27, 2019

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Sep 27, 2019 •
edited by nicolas-grekas
Loading

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #33148 (comment)
License MIT
Doc PR symfony/symfony-docs#...

@ro0NL
Copy link
Contributor Author

ro0NL commented Sep 27, 2019

@nicolas-grekas should form tests in 3.4 pass with intl 4.4? if so, this should be merged in 3.4 as well

@ro0NL ro0NL changed the title [Form][Intl] Fix tests [Form][Validator][Intl] Fix tests Sep 27, 2019
@nicolas-grekas nicolas-grekas added this to the next milestone Sep 27, 2019
@nicolas-grekas nicolas-grekas changed the base branch from 4.4 to 3.4 September 27, 2019 14:00
@nicolas-grekas nicolas-grekas changed the base branch from 3.4 to 4.4 September 27, 2019 14:01
@nicolas-grekas nicolas-grekas changed the base branch from 4.4 to 3.4 September 27, 2019 14:02
@nicolas-grekas nicolas-grekas modified the milestones: next, 3.4 Sep 27, 2019
@nicolas-grekas
Copy link
Member

Thank you @ro0NL.

nicolas-grekas added a commit that referenced this pull request Sep 27, 2019
@nicolas-grekas
minor #33739 [Form][Validator][Intl] Fix tests (ro0NL)
82a62d2 
This PR was merged into the 3.4 branch.

Discussion
----------

[Form][Validator][Intl] Fix tests

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #33148 (comment)
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

e648a91 [Form][Validator][Intl] Fix tests
@nicolas-grekas nicolas-grekas merged commit e648a91 into symfony:3.4 Sep 27, 2019
@ro0NL ro0NL deleted the form-intl branch September 27, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Form Intl Status: Needs Review
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@ro0NL @nicolas-grekas @carsonbot