-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Crawler] document $default as string|null #33742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e4fabab
to
15b8913
Compare
chalasr
reviewed
Sep 28, 2019
darielopper
approved these changes
Sep 28, 2019
15b8913
to
0e6b5a5
Compare
nicolas-grekas
commented
Sep 28, 2019
2eef61d
to
f3b00ad
Compare
f3b00ad
to
e96add4
Compare
nicolas-grekas
commented
Sep 28, 2019
@symfony/mergers OK for you? |
xabbuh
requested changes
Oct 7, 2019
xabbuh
approved these changes
Oct 7, 2019
fabpot
approved these changes
Oct 7, 2019
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 7, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [Crawler] document $default as string|null | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This has been introduced in 4.3 Commits ------- e96add4 [Crawler] document $default as string|null
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been introduced in 4.3