[Cache] fix known tag versions ttl check #33754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darielopper
approved these changes
Sep 29, 2019
kaspervrind
approved these changes
Sep 30, 2019
nicolas-grekas
approved these changes
Sep 30, 2019
|
Thank you @SwenVanZanten. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 30, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Cache] fix known tag versions ttl check | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | none | License | MIT The introduced changes from PR #27007 came with a knownTagVersionTtl property defaulted to 0.15 microseconds. The if statement defined on line 353 checks if the ttl is higher then the already known tag versions. This results in the opposite of the wanted behavior. Instead of waiting for the ttl to expire the if statement is only true if the known versions are lower than the version ttl. So if this Adapter stays in memory the tag versions are never checked again if the ttl is already lower then the passed time. The unit test I've added tests once if the version is changed and another time it doesn't get checked cause the ttl hasn't been expired yet. Commits ------- 205abf3 [Cache] fix known tag versions ttl check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The introduced changes from PR #27007 came with a knownTagVersionTtl property defaulted to 0.15 microseconds. The if statement defined on line 353 checks if the ttl is higher then the already known tag versions. This results in the opposite of the wanted behavior. Instead of waiting for the ttl to expire the if statement is only true if the known versions are lower than the version ttl.
So if this Adapter stays in memory the tag versions are never checked again if the ttl is already lower then the passed time.
The unit test I've added tests once if the version is changed and another time it doesn't get checked cause the ttl hasn't been expired yet.