Sync Twig templateExists behaviors #33792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Because I did not think about it 😓, I will have a look. |
cd81fb1 to
d28558a
Compare
d28558a to
d7682fe
Compare
nicolas-grekas
approved these changes
Oct 2, 2019
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 2, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Sync Twig templateExists behaviors | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - There are 5 places in the code that does the same check, but they are not consistent. The difficulty here is to support Twig 1, 2 & 3. I think relying on `Environment::MAJOR_VERSION` is OK. `method_exists` are useless IMO. The proof is that they are currenty missing in some of them. Basically if Twig >= 2 -> the method `exists` exists on the loader so just call it. For Twig 1, check `ExistsLoaderInterface`, then check for `SourceContextLoaderInterface`, then call `getSource()`. Commits ------- d7682fe Sync Twig templateExists behaviors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 5 places in the code that does the same check, but they are not consistent. The difficulty here is to support Twig 1, 2 & 3. I think relying on
Environment::MAJOR_VERSIONis OK.method_existsare useless IMO. The proof is that they are currenty missing in some of them.Basically if Twig >= 2 -> the method
existsexists on the loader so just call it.For Twig 1, check
ExistsLoaderInterface, then check forSourceContextLoaderInterface, then callgetSource().