Fixed invalid VarDumper upgrade-4.0 doc. #33821
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @adrozdek. |
856d851 to
afefc71
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Oct 3, 2019
This PR was submitted for the 4.3 branch but it was merged into the 3.4 branch instead (closes #33821). Discussion ---------- Fixed invalid VarDumper upgrade-4.0 doc. | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | License | MIT Updated upgrade-4.0 documentation to reflect actual changes in the code. Commits ------- afefc71 Fixed invalid VarDumper upgrade doc.
adrozdek
added a commit
to adrozdek/symfony
that referenced
this pull request
Oct 3, 2019
I changed CHANGELOG.md to reflect actual changes in the code. The third argument is called $filter, not $context. This mistake was propageted to UPGRADE-4.0.md. I fixed that in symfony#33821
fabpot
added a commit
that referenced
this pull request
Oct 3, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Fixed invalid changelog 4.0.0 for VarDumper | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | License | MIT I changed CHANGELOG.md to reflect actual changes in the code. The third argument is called $filter, not $context. This mistake was propageted to UPGRADE-4.0.md. I fixed that in #33821 Commits ------- 169a2b3 Fixed invalid changelog 4.0.0 for VarDumper
symfony-splitter
pushed a commit
to symfony/var-dumper
that referenced
this pull request
Oct 3, 2019
I changed CHANGELOG.md to reflect actual changes in the code. The third argument is called $filter, not $context. This mistake was propageted to UPGRADE-4.0.md. I fixed that in symfony/symfony#33821
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated upgrade-4.0 documentation to reflect actual changes in the code.