Skip to content

[Messenger] Allow to configure the db index on Redis transport #33856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2019
Merged

[Messenger] Allow to configure the db index on Redis transport #33856

merged 1 commit into from
Oct 7, 2019

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Oct 4, 2019 •
edited by nicolas-grekas
Loading

Q A
Branch? 4.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fixes #33724
License MIT
Doc PR todo

Quite useful for testing.

@chalasr chalasr added this to the 4.4 milestone Oct 4, 2019
@chalasr chalasr requested a review from sroze as a code owner October 4, 2019 17:27
@chalasr
Copy link
Member Author

chalasr commented Oct 4, 2019

cc @alexander-schranz FYI

@chalasr chalasr mentioned this pull request Oct 4, 2019
Closed
@nicolas-grekas nicolas-grekas modified the milestones: 4.4, next Oct 4, 2019
alexander-schranz
alexander-schranz approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@alexander-schranz alexander-schranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me. Thank you @chalasr 👍

@nicolas-grekas
Copy link
Member

Thank you @chalasr.

nicolas-grekas added a commit that referenced this pull request Oct 7, 2019
@nicolas-grekas
feature #33856 [Messenger] Allow to configure the db index on Redis t…
ce7c0b4 
…ransport (chalasr)

This PR was merged into the 4.4 branch.

Discussion
----------

[Messenger] Allow to configure the db index on Redis transport

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #33724
| License       | MIT
| Doc PR        | todo

Quite useful for testing.

Commits
-------

115a9bb [Messenger] Allow to configure the db index on Redis transport
@nicolas-grekas nicolas-grekas merged commit 115a9bb into symfony:4.4 Oct 7, 2019
@nicolas-grekas nicolas-grekas mentioned this pull request Oct 7, 2019
Closed
@chalasr chalasr deleted the msg-redis-db branch October 7, 2019 13:03
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot left review comments

@alexander-schranz alexander-schranz alexander-schranz approved these changes

@xabbuh xabbuh xabbuh approved these changes

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Feature Messenger Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

[Messenger] Redis transport should support db-index
6 participants
@chalasr @nicolas-grekas @fabpot @alexander-schranz @xabbuh @carsonbot