Skip to content

[CssSelector] Support *:only-of-type #33861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2019

Conversation

jakzal
Copy link
Contributor

@jakzal jakzal commented Oct 4, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

Before, this pseudo class selector only worked when the element was specified, i.e. p:only-of-type would select all paragraphs which are the only child of its parent.

Now, *:only-of-type is also supported to select any single child.

@jakzal jakzal force-pushed the feature/only-of-any-type branch from 7980ac0 to 8fc5aeb Compare October 5, 2019 06:07
@jakzal jakzal requested review from lyrixx and xabbuh as code owners October 5, 2019 06:07
@jakzal jakzal changed the base branch from master to 4.4 October 5, 2019 06:07
@jakzal jakzal force-pushed the feature/only-of-any-type branch from 8fc5aeb to eae2ebc Compare October 5, 2019 06:27
@fabpot
Copy link
Member

fabpot commented Oct 5, 2019

Thank you @jakzal.

fabpot added a commit that referenced this pull request Oct 5, 2019
This PR was merged into the 4.4 branch.

Discussion
----------

[CssSelector] Support *:only-of-type

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Before, this pseudo class selector only worked when the element was specified, i.e. `p:only-of-type` would select all paragraphs which are the only child of its parent.

Now, `*:only-of-type` is also supported to select any single child.

Commits
-------

eae2ebc [CssSelector] Support *:only-of-type pseudo class selector
@fabpot fabpot merged commit eae2ebc into symfony:4.4 Oct 5, 2019
@jakzal jakzal deleted the feature/only-of-any-type branch October 5, 2019 07:21
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Oct 6, 2019
This PR was merged into the 4.4 branch.

Discussion
----------

[CssSelector] Support *:only-of-type

#12425 and symfony/symfony#33861

![image](https://user-images.githubusercontent.com/1073881/66259057-0160f280-e7ad-11e9-9b1e-9558af79226b.png)

Commits
-------

00584d1 Remove exception for only-of-type selector
This was referenced Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants